From 15c32c0e6d38afedd72ee42cd800d1e61b518c36 Mon Sep 17 00:00:00 2001
From: dswbx <dennis.senn@gmx.ch>
Date: Thu, 18 Sep 2025 10:03:16 +0200
Subject: [PATCH] ui: improve form field components, add support for custom
 fields, export components

Enhanced `FieldLabel` to support tooltips and additional props. Refactored form field components for better customizability and ensured compatibility with new `CustomField`. Updated `onChange` handlers to include context for improved flexibility. Added exports for UI components.
---
 app/src/ui/components/buttons/IconButton.tsx  |  3 +-
 .../ui/components/form/Formy/components.tsx   | 31 +++++++++-----
 .../form/json-schema-form/Field.tsx           | 40 +++++++++++++++----
 .../form/json-schema-form/FieldWrapper.tsx    |  2 +-
 .../components/form/json-schema-form/Form.tsx | 27 +++++++------
 app/src/ui/index.ts                           |  8 ++++
 .../ui/modules/data/components/EntityForm.tsx |  4 +-
 .../fields/EntityRelationalFormField.tsx      |  8 ++--
 8 files changed, 87 insertions(+), 36 deletions(-)

diff --git a/app/src/ui/components/buttons/IconButton.tsx b/app/src/ui/components/buttons/IconButton.tsx
index f0f168c..ca0f4a6 100644
--- a/app/src/ui/components/buttons/IconButton.tsx
+++ b/app/src/ui/components/buttons/IconButton.tsx
@@ -23,7 +23,7 @@ interface IconButtonProps extends ComponentPropsWithoutRef<"button"> {
 }
 
 export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
-   ({ Icon, size, variant = "ghost", onClick, disabled, iconProps, ...rest }, ref) => {
+   ({ Icon, size, variant = "ghost", onClick, disabled, iconProps, tabIndex, ...rest }, ref) => {
       const style = styles[size ?? "md"];
 
       return (
@@ -36,6 +36,7 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
             className={twMerge(style.className, rest.className)}
             onClick={onClick}
             disabled={disabled}
+            tabIndex={tabIndex}
          />
       );
    },
diff --git a/app/src/ui/components/form/Formy/components.tsx b/app/src/ui/components/form/Formy/components.tsx
index 3e95f00..502a844 100644
--- a/app/src/ui/components/form/Formy/components.tsx
+++ b/app/src/ui/components/form/Formy/components.tsx
@@ -1,3 +1,4 @@
+import { Tooltip } from "@mantine/core";
 import clsx from "clsx";
 import { getBrowser } from "core/utils";
 import type { Field } from "data/fields";
@@ -6,6 +7,7 @@ import {
    type ComponentPropsWithoutRef,
    type ElementType,
    forwardRef,
+   Fragment,
    useEffect,
    useImperativeHandle,
    useRef,
@@ -66,17 +68,22 @@ export const ErrorMessage: React.FC<React.ComponentProps<"div">> = ({ className,
    <div {...props} className={twMerge("text-sm text-red-500", className)} />
 );
 
-export const FieldLabel: React.FC<React.ComponentProps<"label"> & { field: Field }> = ({
-   field,
-   ...props
-}) => {
+export const FieldLabel: React.FC<
+   React.ComponentProps<"label"> & { field: Field; label?: string }
+> = ({ field, label, ...props }) => {
    const desc = field.getDescription();
+   const Wrapper = desc
+      ? (p) => <Tooltip position="right" label={desc} {...p} />
+      : (p) => <Fragment {...p} />;
+
    return (
-      <Label {...props} title={desc} className="flex flex-row gap-1 items-center">
-         {field.getLabel()}
-         {field.isRequired() && <span className="font-medium opacity-30">*</span>}
-         {desc && <TbInfoCircle className="opacity-50" />}
-      </Label>
+      <Wrapper>
+         <Label {...props} className="flex flex-row gap-1 items-center self-start">
+            {label ?? field.getLabel()}
+            {field.isRequired() && <span className="font-medium opacity-30">*</span>}
+            {desc && <TbInfoCircle className="opacity-50" />}
+         </Label>
+      </Wrapper>
    );
 };
 
@@ -103,6 +110,12 @@ export const TypeAwareInput = forwardRef<HTMLInputElement, React.ComponentProps<
       if (props.type === "password") {
          return <Password {...props} ref={ref} />;
       }
+      if ("data-type" in props) {
+         if (props["data-type"] === "textarea") {
+            // @ts-ignore
+            return <Textarea {...props} ref={ref} />;
+         }
+      }
 
       return <Input {...props} ref={ref} />;
    },
diff --git a/app/src/ui/components/form/json-schema-form/Field.tsx b/app/src/ui/components/form/json-schema-form/Field.tsx
index 115c79e..60351ca 100644
--- a/app/src/ui/components/form/json-schema-form/Field.tsx
+++ b/app/src/ui/components/form/json-schema-form/Field.tsx
@@ -12,7 +12,7 @@ import * as Formy from "ui/components/form/Formy";
 import { useEvent } from "ui/hooks/use-event";
 import { ArrayField } from "./ArrayField";
 import { FieldWrapper, type FieldwrapperProps } from "./FieldWrapper";
-import { useDerivedFieldContext, useFormValue } from "./Form";
+import { useDerivedFieldContext, useFormValue, type DeriveFn } from "./Form";
 import { ObjectField } from "./ObjectField";
 import { coerce, firstDefined, isType, isTypeSchema } from "./utils";
 
@@ -108,13 +108,13 @@ const FieldImpl = ({
    return (
       <FieldWrapper name={name} required={required} schema={schema} fieldId={id} {...props}>
          <FieldComponent
+            placeholder={placeholder}
             {...inputProps}
             id={id}
             schema={schema}
             name={name}
             required={required}
             disabled={disabled}
-            placeholder={placeholder}
             onChange={onChange ?? handleChange}
          />
       </FieldWrapper>
@@ -131,7 +131,7 @@ export type FieldComponentProps = {
    schema: JsonSchema;
    render?: (props: Omit<FieldComponentProps, "render">) => ReactNode;
    "data-testId"?: string;
-} & ComponentPropsWithoutRef<"input">;
+} & ComponentPropsWithoutRef<"input"> & { [key: `data-${string}`]: string };
 
 export const FieldComponent = ({ schema, render, ..._props }: FieldComponentProps) => {
    const { value } = useFormValue(_props.name!, { strict: true });
@@ -140,10 +140,11 @@ export const FieldComponent = ({ schema, render, ..._props }: FieldComponentProp
       ..._props,
       // allow override
       value: typeof _props.value !== "undefined" ? _props.value : value,
-      placeholder:
-         (_props.placeholder ?? typeof schema.default !== "undefined")
-            ? String(schema.default)
-            : "",
+      placeholder: _props.placeholder
+         ? _props.placeholder
+         : typeof schema.default !== "undefined"
+           ? String(schema.default)
+           : "",
    };
 
    if (render) return render({ schema, ...props });
@@ -202,3 +203,28 @@ export const FieldComponent = ({ schema, render, ..._props }: FieldComponentProp
 
    return <Formy.TypeAwareInput {...props} value={props.value ?? ""} {...additional} />;
 };
+
+export type CustomFieldProps<Data = any> = {
+   path: string;
+   valueStrict?: boolean;
+   deriveFn?: DeriveFn<Data>;
+   children: (
+      props: Omit<ReturnType<typeof useDerivedFieldContext<Data>>, "setValue"> &
+         ReturnType<typeof useFormValue> & {
+            setValue: (value: any) => void;
+            _setValue: (path: string, value: any) => void;
+         },
+   ) => React.ReactNode;
+};
+
+export const CustomField = <Data = any>({
+   path: _path,
+   valueStrict = true,
+   deriveFn,
+   children,
+}: CustomFieldProps<Data>) => {
+   const ctx = useDerivedFieldContext(_path, deriveFn);
+   const $value = useFormValue(ctx.path, { strict: valueStrict });
+   const setValue = (value: any) => ctx.setValue(ctx.path, value);
+   return children({ ...ctx, ...$value, setValue, _setValue: ctx.setValue });
+};
diff --git a/app/src/ui/components/form/json-schema-form/FieldWrapper.tsx b/app/src/ui/components/form/json-schema-form/FieldWrapper.tsx
index aec5b88..784db35 100644
--- a/app/src/ui/components/form/json-schema-form/FieldWrapper.tsx
+++ b/app/src/ui/components/form/json-schema-form/FieldWrapper.tsx
@@ -130,7 +130,7 @@ const FieldDebug = ({
                />
             )}
          >
-            <IconButton Icon={IconBug} size="xs" className="opacity-30" />
+            <IconButton Icon={IconBug} size="xs" className="opacity-30" tabIndex={-1} />
          </Popover>
       </div>
    );
diff --git a/app/src/ui/components/form/json-schema-form/Form.tsx b/app/src/ui/components/form/json-schema-form/Form.tsx
index d52280e..274c162 100644
--- a/app/src/ui/components/form/json-schema-form/Form.tsx
+++ b/app/src/ui/components/form/json-schema-form/Form.tsx
@@ -89,7 +89,7 @@ export function Form<
    validateOn?: "change" | "submit";
    initialOpts?: LibTemplateOptions;
    ignoreKeys?: string[];
-   onChange?: (data: Partial<Data>, name: string, value: any) => void;
+   onChange?: (data: Partial<Data>, name: string, value: any, context: FormContext<Data>) => void;
    onSubmit?: (data: Data) => void | Promise<void>;
    onInvalidSubmit?: (errors: JsonError[], data: Partial<Data>) => void;
    hiddenSubmit?: boolean;
@@ -147,7 +147,7 @@ export function Form<
       setFormState((state) => {
          const prev = state.data;
          const changed = immutable.set(prev, path, value);
-         onChange?.(changed, path, value);
+         onChange?.(changed, path, value, context);
          return { ...state, data: changed };
       });
       check();
@@ -157,7 +157,7 @@ export function Form<
       setFormState((state) => {
          const prev = state.data;
          const changed = immutable.del(prev, path);
-         onChange?.(changed, path, undefined);
+         onChange?.(changed, path, undefined, context);
          return { ...state, data: changed };
       });
       check();
@@ -300,19 +300,20 @@ export function useFormStateSelector<Data = any, Reduced = Data>(
    return useAtom(selected)[0];
 }
 
-type SelectorFn<Ctx = any, Refined = any> = (state: Ctx) => Refined;
+export type SelectorFn<Ctx = any, Refined = any> = (state: Ctx) => Refined;
+export type DeriveFn<Data = any, Reduced = undefined> = SelectorFn<
+   FormContext<Data> & {
+      pointer: string;
+      required: boolean;
+      value: any;
+      path: string;
+   },
+   Reduced
+>;
 
 export function useDerivedFieldContext<Data = any, Reduced = undefined>(
    path,
-   deriveFn?: SelectorFn<
-      FormContext<Data> & {
-         pointer: string;
-         required: boolean;
-         value: any;
-         path: string;
-      },
-      Reduced
-   >,
+   deriveFn?: DeriveFn<Data, Reduced>,
    _schema?: JSONSchema,
 ): FormContext<Data> & {
    value: Reduced;
diff --git a/app/src/ui/index.ts b/app/src/ui/index.ts
index 33a1c59..832e348 100644
--- a/app/src/ui/index.ts
+++ b/app/src/ui/index.ts
@@ -1,3 +1,11 @@
 export { default as Admin, type BkndAdminProps } from "./Admin";
 export * from "./components/form/json-schema-form";
 export { JsonViewer } from "./components/code/JsonViewer";
+
+// bknd admin ui
+export { Button } from "./components/buttons/Button";
+export { IconButton } from "./components/buttons/IconButton";
+export * as Formy from "./components/form/Formy";
+export * as AppShell from "./layouts/AppShell/AppShell";
+export { Logo } from "./components/display/Logo";
+export * as Form from "./components/form/json-schema-form";
diff --git a/app/src/ui/modules/data/components/EntityForm.tsx b/app/src/ui/modules/data/components/EntityForm.tsx
index c82a0c3..63bad58 100644
--- a/app/src/ui/modules/data/components/EntityForm.tsx
+++ b/app/src/ui/modules/data/components/EntityForm.tsx
@@ -270,7 +270,7 @@ function EntityJsonFormField({
 
    return (
       <Formy.Group>
-         <Formy.Label htmlFor={fieldApi.name}>{field.getLabel()}</Formy.Label>
+         <Formy.FieldLabel htmlFor={fieldApi.name} field={field} />
          <Suspense>
             <JsonEditor
                id={fieldApi.name}
@@ -306,7 +306,7 @@ function EntityEnumFormField({
 
    return (
       <Formy.Group>
-         <Formy.Label htmlFor={fieldApi.name}>{field.getLabel()}</Formy.Label>
+         <Formy.FieldLabel htmlFor={fieldApi.name} field={field} />
          <Formy.Select
             name={fieldApi.name}
             id={fieldApi.name}
diff --git a/app/src/ui/modules/data/components/fields/EntityRelationalFormField.tsx b/app/src/ui/modules/data/components/fields/EntityRelationalFormField.tsx
index 8ba4f15..6b4ee77 100644
--- a/app/src/ui/modules/data/components/fields/EntityRelationalFormField.tsx
+++ b/app/src/ui/modules/data/components/fields/EntityRelationalFormField.tsx
@@ -93,9 +93,11 @@ export function EntityRelationalFormField({
 
    return (
       <Formy.Group>
-         <Formy.Label htmlFor={fieldApi.name}>
-            {field.getLabel({ fallback: false }) ?? entity.label}
-         </Formy.Label>
+         <Formy.FieldLabel
+            htmlFor={fieldApi.name}
+            field={field}
+            label={field.getLabel({ fallback: false }) ?? entity.label}
+         />
          <div
             data-disabled={fetching || disabled ? 1 : undefined}
             className="data-[disabled]:opacity-70 data-[disabled]:pointer-events-none"