From ab3e8ce55f3f34b7e76b5941ee15a20df1ff2582 Mon Sep 17 00:00:00 2001
From: dswbx <dennis.senn@gmx.ch>
Date: Thu, 25 Sep 2025 09:25:13 +0200
Subject: [PATCH] fix: set s3 client service to s3 to produce correct headers
 required by minio

---
 .../storage/adapters/s3/StorageS3Adapter.spec.ts    | 13 +++++++++++++
 .../media/storage/adapters/s3/StorageS3Adapter.ts   |  1 +
 2 files changed, 14 insertions(+)

diff --git a/app/src/media/storage/adapters/s3/StorageS3Adapter.spec.ts b/app/src/media/storage/adapters/s3/StorageS3Adapter.spec.ts
index 5a2fe89..62c86b6 100644
--- a/app/src/media/storage/adapters/s3/StorageS3Adapter.spec.ts
+++ b/app/src/media/storage/adapters/s3/StorageS3Adapter.spec.ts
@@ -22,6 +22,19 @@ afterAll(() => {
    cleanup();
 }); */
 
+describe("StorageS3Adapter", async () => {
+   test("verify client's service is set to s3", async () => {
+      const adapter = new StorageS3Adapter({
+         access_key: "",
+         secret_access_key: "",
+         url: "https://localhost",
+      });
+      // this is important for minio to produce the correct headers
+      // and it won't harm s3 or r2
+      expect(adapter.client.service).toBe("s3");
+   });
+});
+
 describe.skipIf(ALL_TESTS)("StorageS3Adapter", async () => {
    if (ALL_TESTS) return;
 
diff --git a/app/src/media/storage/adapters/s3/StorageS3Adapter.ts b/app/src/media/storage/adapters/s3/StorageS3Adapter.ts
index 5926ebe..c36e0e3 100644
--- a/app/src/media/storage/adapters/s3/StorageS3Adapter.ts
+++ b/app/src/media/storage/adapters/s3/StorageS3Adapter.ts
@@ -45,6 +45,7 @@ export class StorageS3Adapter extends StorageAdapter {
             accessKeyId: config.access_key,
             secretAccessKey: config.secret_access_key,
             retries: isDebug() ? 0 : 10,
+            service: "s3",
          },
          {
             convertParams: "pascalToKebab",